400 Errors when hitting API endpoint `alpha/site`

Hello! I am getting 400 errors when hitting the piefed.social. Hitting other piefed instances appear to work.

The exact error I get is:

    
{"code":400,"message":"{'my_user': {'instance_blocks': {0: {'site': ['Missing data for required field.']}}}}","status":"Bad Request"}

As an example I get this error when I make a GET request to https://piefed.social/api/alpha/site.

Note that I am making with request without an Authorization header.

Update

It seems that only alpha/site endpoint is broken. I can GET https://piefed.social/api/alpha/federated_instances just fine.

10 comments

I've merged a fix, is it ok for you now?
- Can confirm that this is now fixed. Thank you!
Ok, I was able to reproduce this and made a PR for a fix. This issue only pops up when a user has instance blocks and works fine otherwise, which is why others in this thread (and myself when I was testing) aren't running into issues.
The root cause really is that I was creating schema for input and output validation to match the manually created swagger docs, but the output for instance_blocks was different than specified (and I marked it as a required field, likely from a copy/paste error). So, thanks for helping us as we are going through endpoints and making them self-documenting.
- Thank you!
Hm. I just clicked it in Firefox and got a response JSON. A good response
- It might be a staged rollout? I think the bug is related to this commit (from 14 hours ago): https://codeberg.org/rimu/pyfedi/commit/a68902e5881677fefcfd707e415372f728866543
- curl looks fine too
  
  Yeah I can curl it just fine. It's only 400ing in the app. I inspected the network request and nothing seems amiss. It was working yesterday and it's only broken on piefed.social.
By the way, I am using this endpoint (https://piefed.social/api/alpha/site) to determine if the server is running PieFed. If there is a better endpoint to use for this purpose please let me know.
- I think that is fine and don't see a problem with that. As for when this issue will get fixed, I merged a fix so other instances hopefully don't get it, but that won't make it onto piefed.social until the Kiwis wake up and @rimu@piefed.social is back online.

10 comments