Developer posts secret key on GitHub, loses $40K in 2 minutes
Developer posts secret key on GitHub, loses $40K in 2 minutes
Web3 developer Brian Guan lost $40,000 after accidentally making his wallet keys public on GitHub.
- Web3 developer Brian Guan lost $40,000 after accidentally posting his wallet's secret keys publicly on GitHub, with the funds being drained in just two minutes.
- The crypto community's reactions were mixed, with some offering support and others mocking Guan's previous comments about developers using AI tools like ChatGPT for coding.
- This incident highlights ongoing debates about security practices and the role of AI in software development within the crypto community.
The developer said he forgot that his secret keys were in the repository.
If you have your secret keys in your repository you've already fucked up, long before you accidentally make that repository public.
370One of the first things you should do in a repo is add a .gitignore file and make sure there are rules to ignore things like
*secret*or*private*etc. Also, I pretty much never usegit add .because I don't like the laziness of it and EVERY TIME one of my coworkers checked in secrets they were using that command.92Even though that's a good extra precaution, per person config data, such as keys, should be stored outside of the repo, eg. in the parent directory or better in the users home dir. There is zero reason to have it in the repo. Even if you use a VM/containers, you can add the config in an extra mount/share.
55Better yet you can configure gitignore globally for git. I do this mostly to avoid polluting repo ignore files with my editor specific junk but *.key and similar can help prevent accidents.
6I never understood why everyone uses it as a ignore list. In my own and work repositories I always exclude everything by default and re-add stuff explicitly. I have had enough random crap checked in in the past by coworkers. Granted, the whole source folder is fully included but that has never been a problem.
5git add -uis pretty nice, it only adds modified files.I usually do
git add -pwhich is interactive (helps avoid committing debugging prints and whatnot), but the other is nice for bigger refactors.1
I use this as a pre-commit hook https://github.com/americanexpress/earlybird
44And that’s why you always
leave a noterecheck your .gitignore file before committing26You can also do
git diff --cachedto see all changes you added to the index.1
Ehhh. I mean, I have local repositories that contain things that I wouldn't want to share with the world. Using git to manage files isn't equivalent to wanting to publish publicly on github.
I could imagine ways that private information could leak. Like, okay, say you have some local project, and you're committing notes in a text file to the project. It's local, so you don't need to sanitize it, can put any related information into the notes. Or maybe you have a utility script that does some multi-machine build, has credentials embedded in it. But then over time, you clean the thing up for release and forget that the material is in the git history, and ten years later, do an open-source release or something.
I do kind of think that there's an argument that someone should make a "lint"-type script to automatically run on GitHub pushes to try and sanity-check and maybe warn about someone pushing out material that maybe they don't want to be pushing to the world. It'll never be a 100% solution, but it could maybe catch some portion of leakage.
7Users often don't take care to separate private and public environments. They just dump all their stuff into one and expect their brain to make the correct decision all the time.
Put your private data into a private space. Never put private data into a mixed use space or a public space.
e.g. Don't use your personal email at work. Don't use your personal phone for business. Don't put your passwords or crypto keys in the same github or gitlab account or even instance and don't reuse passwords and keys, etc.
16Having plain text secrets, or having secrets at all in a repository is always a bad practice. Even if it's a super-duper private/local/no one will ever see this repo.
14That's exactly what pre-commit.com project is doing
3
I have no sympathy for him, if he is a crypto developer he knows how important those private keys are. And he also knows people scrape public areas all the time looking for keys just like that. The whole point of crypto is to be immutable, so that money is simply lost to him now.
He seems to know how much of a dumb mistake that was, although his description of himself was a bit more colorful.
124You're not wrong about how important those keys are and how he definitely should have known better. But I at least have a little sympathy for the guy. Everyone makes mistakes from time to time, even with important stuff. Hopefully they are lucky enough not to lose 40k on one but unfortunately he wasn't. Whether he should have known better or not, that just plain sucks.
12The whole point of crypto is to be immutable, so that money is simply lost to him now.
IIRC there are several cases where some group of people lost big enough coins and force most of the miners to fork to get their money back. Not bitcoin though.
11If that doesn't make everyone lose 100% trust in coins that do that, I don't know what will.
21
Permanently Deleted
110Did we not learn our lessons from Web 2.0?
10Got me good
6The most wild thing to me is the mental gymnastics of trying to be pro web3 but anti-LLM assisted development. LLMs are at least occasionally useful.
1
It must be automated for it to happen in 2 minutes. Which implies these kind of things happen often enough for someone to write a script for it.
82Yes, it absolutely is automated.
There are bots running constantly looking for things that match patterns for exploitable credentials in public commits.
AWS credentials
SSH keys
Crypto wallets
Bank card info
If you push secrets to a public github repo, they will be exploited almost immediately.
92If it was a script I wrote, it would have successfully stolen the $40k, but also stolen my own money and deposit both sets of money into a second intended victims account because I forgot to clear a variable before the main loop runs again.
59You always mess up some mundane detail!
15It would have deposited the funds in an account "foobar123" and been lost forever
4Might have happened in this case too, you never know.
1
Oh yes absolutely, there are bots constantly crawling any open source code. A friend of mine accidentally leaked their discord API key, nuked a whole server within minutes.
20There must be bots trolling GitHub for API keys, crypto secret keys, and other such valuable data
8
I'm sad I didn't see any comments saying he shouldn't be using a $40k wallet key to test his software in the first place. Anything could happen with simple code mistakes...just get an empty wallet or one with a few bucks in it.
55If there was any sort of password / highly entropic string detection in their build pipeline it would have caught a wallet's keys. They aren't an excuse for lack of diligence, but they should still be in every pipeline where passwords or keys might have to get used.
I'm terrible about building pipelines for most of my personal projects though, so I'm throwing rocks from my glass house here.
38I like your CI plan but maybe they just needed some sort of sane policy. Like never commit plaintext keys to any repo. Never work with a $40k key in a new project under development. Never convert a private repo to public.
9A CI pipeline wouldn't fix this since the code would be committed before the pipelines run. This needs to be caught on the dev's machine with a pre-commit or pre-push hook.
2
There’s a reason we use .env files and put them in gitignore.
20I use a text file version of a novel to back up my keys, then I store the key map in multiple cloud drives. For example, if the word is "lighting" then my key map for that word would be 487,5 (line 487, word 5). Easy to crack, if you know what novel I am using.
11That's the copy protection on dozens of computer games from the 90s.
31To get my codes you have to play Alone in the Dark 2, and have the original 2 sided playing cards, then translate that into Brittanic runes and find the latitude and longitude of the given city on a cloth map from the original Ulitma.
6Well, I am a Gen-X'r.
5Chuck Yeager's air combat!
2It's also even older in use in communicating secretly, known as a Book Cipher. You and your recipient get the same copy of a book and agree to one of a few numbering schemes, the plaintext message becomes numbers that correspond with words in the book.
1
What a muppet
10Incredibly funny story, incredibly awful website.
6