I do the same, but... I don't use my shared storage for my piholes. I have two of them, one on each miniPC in my Proxmox cluster, on local storage, and then PBS (with in guest iSCSI) backs them up to my backup storage.
Reason being, redundant DNS. I lose a node, or lose shared storage? I will still have DNS.
I did similar a little over a year ago, I got tired of trying to justify things to keep my pi 3 in service. Had a ProxMox cluster of Intel NUCs running so just created lxc containers for everything I had on the pi. Now with HA!!
Sounds nice. I use a similar setup, only my server is a mini PC with 12gbs of RAM and 1TB msata.
Instead of VMs I use Linux containers with ubuntu as base. Then I run full-fat applications like Wazuh, checkmk and docker containers. I tend to use one LXC per function. I even host my personal blog in this setup. No piercied firewall here for public facing services. I'm using clouflare tunnels and access.