I'll controversially say that I really love the Steam controller. Not the steam deck (which is honestly my number 1 if we're including handhelds) but the original controller intended for use with the steam link device.
It really just needs a right analog stick and it would be great. The lack of one takes it from 10/10 to like a 7/10. It's so good otherwise, great weight and size, good design. Sensible layout and the big track pads work really well! It was clearly a prototype for how the Deck layout ended up, though I actually like the controller's big circular pads more than the decks little square ones.
At the moment, my PS5 controller connected to my Linux PC via USB-C.
It has perfect support due to official in kernel drivers from Sony and very little lag when used via USB-C.
adjustable tension springs and locking mechanism for varied stick cap types (Xbox Elite series 2 does most of this but uses magnetic caps which would interfere with the TMR sticks so ball bearing connections or other option would be preferable)
Adaptive haptic triggers (PS5) which can be toggled to hair trigger mode via switches (Xbox Elite series 2)
multi-touchpad on face (PS5)
analog face buttons (DualShock 2 controller had this but only a few games utilized this… the best example was the PS2 era Metal Gear Solid games)
customizable “per-button” color assignment / micro OLED or e-ink screens so button graphics can be swapped (PBTails new controller does the per button RGB color assignment)
USB-C / 4 wired connectivity + charging
baseplate contact-charging (PS5 controller has these so you can set them on charging docks)
hot swappable battery pack + AA battery holder pack or ability to not have a battery on at all when connected via USB-C (Xbox 360 controller had this)
swappable non-magnetic Zinc-alloy faceplates (PBTails new controller has these)
removable back triggers with dedicated button assignments (like the Steam Deck’s L4/5 and R4/5 buttons; not just cloned face buttons like Sony and XBox do)
integrated microphone with hardware toggle (PS5)
proper “separate keys” d-pad… not the mushy type
touch-sensitive surfaces for every button and stick (Meta / Oculus Quest controllers do this)
per-finger-joint touch sensitive grips for each finger segment (Valve’s VR controllers did this)
the ability to separate the halves of the controller so that each hand could hold one half independently and have them track similar to most standard VR controllers (think combining the switch controllers and Quest controllers)
NFC communication (Amiibo-stuff for example)
If any single controller did even half of this, they’d easily be the GOAT.
8bitdo SN30 pro. Small, lightweight, perfect button placement. SNES controller designers knew their shit, just add two sticks and a pair of triggers and you can play almost anything with it.
For fighting games, my own custom built stick. Put this together last year to replace the Hori RAP4 that had served me well for seven years until a button cap broke off. Super happy with how this turned out. It's much lighter, I like having a detachable cable. GP2040-CE supports Switch natively so I no longer need an adapter (and I can feel the difference in latency now), and Sanwa silents mean I can practice late at night without keeping anyone awake. And it just looks good, it's on brand for me.
For everything else that is not fighting games, 8BitDo Pro 2.
I also have a soft spot for the Wii Classic Controller Pro, I miss having gates on the analog sticks. I'd kill for a modern refresh of that with L3/R3, gyro, and USB instead of having to plug it into a Wiimote.
My favorite layout so far is on the Razer Wolverine V2 Chroma Xbox wired controller. It has x/y up between the shoulder and triggers, back buttons for a/b, so you can keep your right thumb on the thumbstick without moving it to hit face buttons a/b/x/y.
Switch Pro controller for its asymmetrical layout + gyroscope (it’s so much better for aiming). I’d love to test a PS5 controller but symmetrical layout tend to hurt my hands (it was already the case for the PS3/PS4 controllers, so I have little hope for the PS5 controller).
I have been playing videogames since 1992. Went through almost every controller design possible. From the modern ones, I never liked the layout from the playstation so sticked to Xbox.
At the moment I'm using a GameSir T4 Kaleid and absolutely loving it. Mechanical buttons and hall effect joystick are very nice. Since I've had it only for a year I can't say anything about reliability.
Most reliable Xbox controllers in order are Xbox classic controller S, 360, One. After that every single one is bad IMO.
Series controller start to drift pretty fast, same as both elites.
So at the moment my most favourite is the Xbox One controller 2nd revision (1708) also known as Xbox one S controller but if the GameSir won't break for the next couple of years it will be the top one for me.
I hope more first party controllers will get a proper higher tier version with real reliable parts like everything hall effect and mechanical buttons...
I really love the current gen controllers. I was using a Series X controller, which has a fantastic weight and feel, but I started experiencing drift. I decided to get a PS5 controller after that, and it's even better! I use it with my PC, and the touchpad works as a mousepad, which has allowed me to play a LOT of games comfortably on the couch, when I'd normally have to fumble with my mouse and keyboard.
Right now I’m mostly using the Xbox One controller (on PC). It’s a controller that feels really good to hold. No weird gimmicks like motion control either. I think it’s one of the all time greats.
Switch pro controller previously and Xbox controller lately. I especially like the detachable AA batteries of the Xbox controller as I can charge extra batteries separately.
To be specific, the Xbox One Elite controller. I really liked the Series 2 but it fell apart on me. I never had much issue with the original. I'm a glutton for punishment though, and I'd get another Series 2. I don't mind working on them so it isn't the biggest deal
I really love the Switch Pro controller, but I wish it had analog triggers. I also have love for the GameCube controller. I am at home with the N64 controller, but I can't say it's a favorite
It's probably because I have bias, but I've never cared for any of Sony's offerings. Something about the sticks doesn't feel right with both being at the bottom
An Xbox one controller. I bought a newer seriesX controller but it developed stick drift almost immediately. My Xbox one controller is going on 6 or 7 years now and is still rock solid. And I play rocket league so you know I am hard on them.
First of all, favorite for what? For accesibility reasons if it's not a dual stick game I am defaulting to a fightbox-type device these days. I favor a WASD configuration, rather than a thumb-for-up configuration and I currently favor a tiny, minimalist haute board box with cherry switches (blue for buttons, greys for WASD). It's great, it lies on my desktop and it causes minimal strain even in high APM games.
For dual stick stuff, it again depends. Is this a shooter where aiming is a factor? Because then I'm gonna want some gyro. The DualSense is amazing to hold, just bonkers build quality. It is heavy and ugly as sin, though. It also doesn't work perfectly with every PC game, so it feels like a hassle to use it as my default. There's the KK3, which has gyro in Switch mode and seems to be less fussy than the DualSense. Plus they are trying to sell their hall effect sticks to third parties, so those are very smooth. It is a jack of all trades, though, and I actively hate KK's dumb extra button configuration, with start and select all the way at the top, I keep pressing the screenshot buttons by accident.
If there's no twitch aiming, and thus no major need for gyro, Victrix's Pro BFG is fun. It has modular design where you can put the dpad on either location. The dpad isn't great, but hey, the fightbox's there for that. It does have a six button configuration, too, if you're a controller fighting game guy. The best feature, though? Replaceable eight-way gates for the sticks, Gamecube-style. If you're a Smash guy or emulating Gamecube it's such a no-brainer high end replacement.
But honestly? Honestly?
The JoyCon.
I know people hate the JoyCon, but the idea of a split controller is amazing to me, and everybody else who has tried to do it, Lenovo Legion Go included, gets it wrong. The big handles aren't the answer without a middle segment to hold the controllers. The two little boards are fantastic for 3D action games, the amount of tech in such a small frame is astounding and the button-based dpad is so good I'm using fightboxes on the regular now. It's a shame there are some reliability issues, but I would buy a device just like it for PC tomorrow if they could sort out connectivity reliably.
Although I grew up with Playstation controllers in my hands, ever since I tried an XBox 360 controller I never went back. I've been using XBone controllers on my PC for years now, and I just love the ergonomics of them in my hand, the clicky D-pad, the rounded buttons. I've always hated the PS dpad, it hurts my thumb. Now, I probably won't keep buying "original" XBox controllers, but anything with that shape and feels that comfortable in my hand, will be my choice.
Back in the day, I think it was Logitech or similar who redesigned a PlayStation controller with some minor ergonomic tweaks. It was a masterpiece. This was back in maybe PS2/PS3 era.
Sounds see if any modern versions exist. I'm still a Sony controller purist, having never really fallen in love with Xbox like so many others.
I haven't tried everything out there, but so far nothing I've tried is true perfection. The controller I use as daily driver for my PC is an Xbox 360 controller, which I find extremely nice - except for the D-pad. It also lacks the fancy tricks of the PS5 controller - a controller I Iike less for ergonomics but love for stuff like haptic feedback.
I picked up a Gamesir x2 recently and it really ticks all but one of the boxes for me. It's a liiiiittle too big to carry around in a pocket, and a liiiittle too small if you've got bigger hands, but its still great at what it does.
I can't say I've ever really liked a controller, so I never experimented with fancy ones. The one that was the most fine was the ps controller. the joycon was ok until drift kicked in. The xbox controller made my hands hurt after too long. I think if I'd had more xbox games back then I would have gotten more into controllers to find one for my tiny hands. I mostly prefer a keyboard.
Right now, a kind of weird one: the Bridget MX, from SGF Devices. It's a 3D printed, all-button controller for fighting games. They don't make that specific model now (it was a very early one), but this is the closest to it: https://sgfdevices.com/products/bridget-pe
At first I thought that not having a joystick would make games kind of boring. Like, too practical, not enjoyable. But no, it's actually fun. Kind of like tapping out notes on a piano. It uses low-profile mechanical keyboard switches, and I have some stiffer, clickier switches on the way right now.
It's meant for fighting games (Street Fighter, etc.), but I've used it for some 2D platformers and it worked great for those, too.
A non-3D-printed, less cheapo one would probably be even more fun to use, but I think I'll stick with this one for now.
The chameleon wireless PS2 pelican controller. Fits hands perfectly, light weight, just feel perfect, I'd pay so much to be able to use it on modern systems.
I love the XBOX Lunar Shift controller, it seems like they added a nice rubber coat around the - what do you call these - wings? so it has a very nice feel to it. Sadly, of course, still no hall sticks.
But I also haven‘t really tried a dozen different controllers so I‘m not sure how helpful my opinion is.