Vote on preferred design for subscribing from search
Since there is no way currently to quickly and easily subscribe to a community from the search menu, sharunkumar (not me) added a way to do that in this pull request.
There are 2 poosible designs that are consistent with UI of voyager so I will comment the images of the design below. Upvote the design that you prefer. Please refrain from downvoting.
A single visual clue should be linked to a single behaviour. Design 2 has two visual clues for one thing (filled heart and crossed out), that's one too much.
I'd much rather prefer consistent design with the rest of the app. This would mean a possible Design 3: Stroked heart, no filling, and crossed out when the button will unsubscribe you
Also it brings to fore a wider debate. Should that button denote the current status or should it denote the action that will happen on pressing the button.
A favourite is not a subscription, right? Although, I've got to agree with you that a consistent style across favourites and subscriptions would be nice
Consistent interface design would be extending or replicating existing ways to open menu options, i.e.
a. Select the community from the search, then use the hamburger to access the menu and select Subscribe (current behaviour)
b. Press and hold on the community name from search to open a limited menu and select Subscribe (new behaviour, replicates functionality in the posts interface)
The number of actions to be taken to subscribe in these cases are way more than the one action you need to take in the solution Sharun has proposed so they would slower and more difficult. This method also quickly informs users as to which community they are subscribed to, which considering the number of duplicate communities is also very useful
Also voyager has set a precedent where you can quickly favourite unfavourite a community from the side tab by clicking on a star toggle/indicator so this design is not a completely new concept and is consistent with what voyager uses currently