Remove "final" keywords from classes and methods in vendor packages with Unfinalize
Remove "final" keywords from classes and methods in vendor packages with Unfinalize
Unfinalize is a package that uses PHP CS Fixer to permanently remove `final` keywords from composer vendor packages.
For me personally this feels very wrong. What do you think about that?
Final keywords–like locks on a door–are just a suggestion. If someone wants to light a stick of dynamite and play hot potato with it, that's their own problem. As long as they aren't wasting upstream dev's time or publishing packages that depend on this to work, it's not worth getting upset about.
5As long as they aren't wasting upstream dev's time or publishing packages that depend on this to work
But exactly this will happen.
5That's gonna be the quickest issue close I am even capable of. As soon as you have problem with extending a class that's not extendable, well, sounds like a you problem.
1
Just because one person said "final is bad", the Laravel fanboy herd is flocking to solutions like this. In my opinion, the package per se is not bad, but the unreflected, absolute statement "final is bad" is the problem.
2In my opinion, the package itself is bad. It suggests by its very existence that
finalis bad. It tempts to use dependencies in a way that was not intended by their developers.1This. And, unlike Lombok, there is no -deUnfinalize. Sure seems like youre stuck with fixing your codebase, when this thing finally folds.
2Yes the package pushes the notion "final is bad". Throw both into the trash.
1
Another red flag for people hired to maintain that code, I guess.
2